Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/824#discussion_r123316880
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java 
---
    @@ -179,10 +182,18 @@ private Metadata(FileSystem fs, ParquetFormatConfig 
formatConfig) {
     
         for (final FileStatus file : fs.listStatus(p, new DrillPathFilter())) {
           if (file.isDirectory()) {
    +        String subdirectoryName = file.getPath().getName();
             ParquetTableMetadata_v3 subTableMetadata = 
(createMetaFilesRecursively(file.getPath().toString())).getLeft();
    -        metaDataList.addAll(subTableMetadata.files);
    -        directoryList.addAll(subTableMetadata.directories);
    -        directoryList.add(file.getPath().toString());
    +        for (ParquetFileMetadata_v3 pfm_v3 : subTableMetadata.files) {
    +          // Construction of the relative file path by adding subdirectory 
name and inner relative file path
    +          String relativePath = Joiner.on("/").join(subdirectoryName, 
pfm_v3.getPath());
    --- End diff --
    
    Regarding the `paths` I answered in the general comment. 
    
    I refused from merging path names recursively. Instead of that I've 
implemented a new `MetadataPathUtils.createMetadataWithRelativePaths()` method 
that converts absolute paths to relative ones and creates a new metadata for 
the cache files. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to