Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/824#discussion_r123329475
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -264,15 +275,18 @@ private ParquetTableMetadata_v3
getParquetTableMetadata(List<FileStatus> fileSta
/**
* Get a list of file metadata for a list of parquet files
*
- * @param fileStatuses
- * @return
+ * @param parquetTableMetadata_v3 can store column schema info from all
the files and row groups
+ * @param fileStatuses list of the parquet files statuses
+ * @param absolutePathInMetadata true if result metadata files should
contain absolute paths, false for relative paths.
+ * Relative paths in the metadata are only
necessary while creating meta cache files.
+ * @return list of the parquet file metadata (parquet metadata for every
file)
* @throws IOException
*/
- private List<ParquetFileMetadata_v3> getParquetFileMetadata_v3(
- ParquetTableMetadata_v3 parquetTableMetadata_v3, List<FileStatus>
fileStatuses) throws IOException {
+ private List<ParquetFileMetadata_v3>
getParquetFileMetadata_v3(ParquetTableMetadata_v3 parquetTableMetadata_v3,
+ List<FileStatus> fileStatuses, boolean absolutePathInMetadata)
throws IOException {
--- End diff --
Using of boolean flag is deleted.
For now we create and gather metadata only with absolute paths. But before
writing based on the old metadata the new metadata with relative paths is
created.
Agree. It makes sense to check every path while converting it. Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
