Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123865494
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -38,8 +44,12 @@
// methods for compatibility.)
class DrillStatementImpl extends AvaticaStatement implements
DrillStatement,
DrillRemoteStatement {
+ //Not using the DrillbitContext's ExecutorService as this is threadPool
is light-weight (threads wake up to cancel tasks) but needs a low response time
+ private static ExecutorService queryTimeoutTaskPool =
Executors.newCachedThreadPool(new NamedThreadFactory("q-timeout-"));
--- End diff --
Using a threadPool model is actually making the solution simpler, since I'm
triggering the query cancellation. The TimeoutTrigger class uses an
executorService for this cleanly, without exposing anything else. Checking
constantly for the remaining time seemed like an overhead that would be
cumulatively add to the runtime.
The one benefit of doing this in the Cursor would be that I could,
potentially, have a new QueryState defined as TIMED_OUT, but I'm reluctant to
modify the Protobuf as of now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
