Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123866148
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -98,6 +102,32 @@ private void throwIfClosed() throws
AlreadyClosedSqlException,
}
}
+ /**
+ * Throws SqlTimeoutException if the statement has already timed out
+ * @throws AlreadyClosedSqlException if Connection is closed
+ * @throws SqlTimeoutException if Statement is already timed out
+ */
+ private void throwIfTimedOut() throws AlreadyClosedSqlException,
+ SqlTimeoutException,
+ SQLException {
+ if ( (statement instanceof DrillStatementImpl && ((DrillStatementImpl)
statement).isTimedOut()) ||
--- End diff --
since PreparedStatement extends from Statement, maybe
DrillPreparedStatement should extends DrillStatement? this way, you could add
isTimedOut to the interface? (but you would not need to if done in DrillCursor
;-))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
