Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/870#discussion_r126840055
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -155,6 +155,10 @@ drill.exec: {
         enabled: false,
         max_chained_user_hops: 3
       },
    +
    +  // Setting to control security for storage_plugins. For now this is only 
for Hive
    --- End diff --
    
    Better:
    
    ```
    security: {
      user.auth.enabled: false,
      storage_plugin_enabled: false
    }
    ```
    
    That way, it will be clear that the two properties go together. Move your 
comment inside the brackets.
    
    Now, it is a hassle that some previous properties used dots as word 
separators: they are actually group separators...
    
    Then, if users must set this option, please add this property as an example 
in `drill-override-example.conf`. Provide a user-understandable instruction for 
what to do. Also, please mark this JIRA as doc-impacting if it is not already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to