Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/870#discussion_r126854772
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java
 ---
    @@ -260,6 +289,10 @@ public StoragePlugin createOrUpdate(String name, 
StoragePluginConfig config, boo
     
           if (done) {
             if (persist) {
    +          if (!config.isValidSecurityConfig(secureStoragePlugin)) {
    +            logger.warn("Security setting for {} plugin is not recommended 
one. It should be set to: {}",
    --- End diff --
    
    This will cause confusion if we let the user update the storage plugin 
config ignoring the drill security config. I agree with Paul this can be messy, 
with things getting out of sync. We should discuss about this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to