Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r128129092
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/PriorityQueueCopierWrapper.java
---
@@ -100,10 +102,12 @@ private PriorityQueueCopier
newCopier(VectorAccessible batch) {
* @param batchGroupList
* @param outputContainer
* @param targetRecordCount
+ * @param allocHelper
* @return
*/
- public BatchMerger startMerge(BatchSchema schema, List<? extends
BatchGroup> batchGroupList, VectorContainer outputContainer, int
targetRecordCount) {
- return new BatchMerger(this, schema, batchGroupList, outputContainer,
targetRecordCount);
+ public BatchMerger startMerge(BatchSchema schema, List<? extends
BatchGroup> batchGroupList,
--- End diff --
Would probably do it that way if either a) it wasn't test code, or b) the
allocation thing was not temporary.
The sort code probably should actually create a vector allocator so we test
what we ship. But, haven't got to that step yet.
Also, hoping that the vector allocator (and sizer) disappear into a larger
form of batch metadata.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
