Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r128367935
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortConfig.java
---
@@ -114,15 +127,25 @@ public SortConfig(DrillConfig config) {
} else {
mSortBatchSize = Character.MAX_VALUE;
}
+
+ // Disable the single-batch shortcut; primarily for testing
+
+ if (config.hasPath(ExecConstants.EXTERNAL_SORT_OPTIMIZE_SINGLE_BATCH))
{
+ enableSingleBatchShortcut =
config.getBoolean(ExecConstants.EXTERNAL_SORT_OPTIMIZE_SINGLE_BATCH);
+ } else {
--- End diff --
Yes. But the "final" provides useful information: the value can't change
once set. Once we accept "final" then we're stuck with the awkward code to
initialize the value only once.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
