Github user weijietong commented on a diff in the pull request:

    https://github.com/apache/drill/pull/889#discussion_r135254275
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinUtils.java
 ---
    @@ -231,6 +236,12 @@ public static boolean isScalarSubquery(RelNode root) {
             return true;
           }
         }
    +    if (!hasMoreInputs && currentRel != null) {
    +      Double rowSize = 
RelMetadataQuery.instance().getMaxRowCount(currentRel);
    --- End diff --
    
    I agree that we should rewrite the method by call 
RelMetadataQuery.getMaxRowCount(). btw, could you give a guide how calcite do 
that ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to