Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/938#discussion_r137939296
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -545,16 +584,19 @@ public AggOutcome doWork() {
if (EXTRA_DEBUG_1) {
logger.debug("Starting outer loop of doWork()...");
}
- for (; underlyingIndex < currentBatchRecordCount; incIndex()) {
+ while (underlyingIndex < currentBatchRecordCount) {
if (EXTRA_DEBUG_2) {
logger.debug("Doing loop with values underlying {}, current {}",
underlyingIndex, currentIndex);
}
checkGroupAndAggrValues(currentIndex);
+
+ if ( retrySameIndex ) { retrySameIndex = false; } // need to
retry this row (e.g. we had an OOM)
--- End diff --
I think Drill's coding style guidelines says no spaces after ( or before ).
---
