[GitHub] drill pull request #938: DRILL-5694: Handle HashAgg OOM by spill and retry, ...

[Ben-Zvi]

Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/938#discussion_r138236560
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java
 ---
    @@ -293,7 +299,7 @@ private HashAggregator createAggregatorInternal() 
throws SchemaChangeException,
             aggrExprs,
             cgInner.getWorkspaceTypes(),
             groupByOutFieldIds,
    -        this.container);
    +        this.container, extraNonNullColumns * 8 /* sizeof(BigInt) */);
    --- End diff --
    
    Not sure .... seemed to work OK in some (limited) testing.


---