[GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories

[paul-rogers]

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/940#discussion_r138473108
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSimpleExternalSort.java
 ---
    @@ -148,10 +149,10 @@ public void sortOneKeyDescendingExternalSortLegacy() 
throws Throwable {
     
       private void sortOneKeyDescendingExternalSort(boolean testLegacy) throws 
Throwable {
         FixtureBuilder builder = ClusterFixture.builder()
    -        .configProperty(ExecConstants.EXTERNAL_SORT_SPILL_THRESHOLD, 4)
    -        .configProperty(ExecConstants.EXTERNAL_SORT_SPILL_GROUP_SIZE, 4)
    -        .configProperty(ExecConstants.EXTERNAL_SORT_BATCH_LIMIT, 4)
    -        .configProperty(ExecConstants.EXTERNAL_SORT_DISABLE_MANAGED, false)
    +        .configProperty(OptionValidator.OPTION_DEFAULTS_ROOT + 
ExecConstants.EXTERNAL_SORT_SPILL_THRESHOLD, 4)
    --- End diff --
    
    These options are boot options, not runtime options, so no need for the 
prefix (unless someone changed something.)


---