Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138489633
--- Diff:
common/src/test/java/org/apache/drill/categories/package-info.java ---
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/**
+ * This package stores the JUnit test categories.
+ */
--- End diff --
Currently there are two broad categories: **Fast** and **Secondary**. The
**Fast** tests are smoke tests. The **Secondary** tests are for slow tests. I
can add a third **BugFix**category to represent tests for specific bugs.
The rest of the categories represent broad groups of tests. Some of those
categories have tests which span multiple class files and multiple packages. An
example of such a category is **OperatorTest**, **PlannerTest**, or
**SqlTest**. These categories are helpful when you are making a change in a
particular area since they allow you to run all the tests for that area easily,
and also effectively serve as a form of documentation. For example it would
have been helpful to have an <b>OptionsTest</b> category when I was making the
option system changes, since it took me a while to find all the relevant test
classes and I had to construct a long maven command to run the tests.
Also the structure of the tests as they are now is somewhat counter
intuitive because tests can span different modules. For example consider the
vector submodule. One would think all the relevant tests for vectors are in
that submodule, but currently they are not. In fact there are no unit tests in
the vector submodule and all relevant vector tests are in java-exec. Also the
memory submodule has tests in it and a relevant test in the java-exec module
as well.
Some categories I agree are redundant like HiveStorageTest. Those tests
have a clear one to one mapping to their submodule, however, I included a
category for them as well for the sake of consistency. This way we can have a
uniform mechanism for running subsets of tests instead of one mechanism for
some groups of tests and another mechanism for other tests.
To summarize, I can add a **BugFixTest** category to add another level of
distinction between **Secondary** tests. But I am compelled to keep the other
test categories intact for the reasons outlined above. Let me know what you
think.
---
