[GitHub] drill pull request #938: DRILL-5694: Handle HashAgg OOM by spill and retry, ...

[Ben-Zvi]

Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/938#discussion_r138495914
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java
 ---
    @@ -158,19 +158,17 @@ public BatchHolder(int idx) {
           } finally {
             if (!success) {
               htContainer.clear();
    -          if (links != null) {
    -            links.clear();
    -          }
    +          if (links != null) { links.clear();}
             }
           }
         }
     
         private void init(IntVector links, IntVector hashValues, int size) {
           for (int i = 0; i < size; i++) {
    -        links.getMutator().setSafe(i, EMPTY_SLOT);
    +        links.getMutator().set(i, EMPTY_SLOT);
    --- End diff --
    
    This init() method is not used .... looks like leftover old code 


---