[GitHub] drill pull request #950: DRILL-5431: SSL Support

[sohami]

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/950#discussion_r140401069
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicServer.java 
---
    @@ -203,6 +226,9 @@ public void close() throws IOException {
           if (elapsed > 500) {
             logger.info("closed eventLoopGroup " + eventLoopGroup + " in " + 
elapsed + " ms");
           }
    +      if(isSslEnabled()) {
    --- End diff --
    
    `if(isSslEnabled())` check not required here and in `BasicClient` since 
`closeSSL` is taking care of it.


---