Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/950#discussion_r140400292
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicServer.java
---
@@ -105,6 +109,25 @@ protected void initChannel(SocketChannel ch) throws
Exception {
// }
}
+ // Adds a SSL handler if enabled. Required only for client and server
communications, so
+ // a real implementation is only available for UserServer
+ protected void setupSSL(ChannelPipeline pipe) {
+ // Do nothing
+ }
+
+ protected boolean isSslEnabled() {
+ return false;
+ }
+
+ // Save the SslChannel after the SSL handshake so it can be closed later
+ public void setSslChannel(Channel c) {
+ return;
+ }
+
+ protected void closeSSL() {
+ return;
+ }
--- End diff --
redundant `return` statement in both `closeSSL` and `setSSLChannel`.
---
