Github user sachouche commented on a diff in the pull request:
https://github.com/apache/drill/pull/970#discussion_r143020963
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
---
@@ -184,25 +183,26 @@ public void testAllScalarTypes() throws Exception {
try {
// read all of the types with the complex reader
- test(String.format("alter session set %s = true",
ExecConstants.PARQUET_NEW_RECORD_READER));
+ alterSession(ExecConstants.PARQUET_NEW_RECORD_READER, true);
--- End diff --
Paul,
- I noticed the key PARQUET_NEW_RECORD_READER is erroneous
- There are currently two readers
o The old one is used when nested data is used as it can handle all
parquet use-cases
o The new reader only deals with Flat parquet data types
- We might want to rename the keys as the new reader cannot always be
substituted with the old one
---
