Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144132366
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java ---
@@ -90,12 +89,11 @@
private String generatedCode;
private String generifiedCode;
- CodeGenerator(TemplateClassDefinition<T> definition,
FunctionImplementationRegistry funcRegistry, OptionSet optionManager) {
- this(ClassGenerator.getDefaultMapping(), definition, funcRegistry,
optionManager);
+ CodeGenerator(TemplateClassDefinition<T> definition, OptionSet
optionManager) {
+ this(ClassGenerator.getDefaultMapping(), definition, optionManager);
--- End diff --
Does the code actually work without this item? Isn't the registry where we
store UDF functions? And, doesn't the expression materializer make use of this
info to copy UDFs inline into the generated code?
If we can remove this, that is a big convenience. But, I'm skeptical that
it is, in fact, not needed.
---
