Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144194241
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java ---
@@ -90,12 +89,11 @@
private String generatedCode;
private String generifiedCode;
- CodeGenerator(TemplateClassDefinition<T> definition,
FunctionImplementationRegistry funcRegistry, OptionSet optionManager) {
- this(ClassGenerator.getDefaultMapping(), definition, funcRegistry,
optionManager);
+ CodeGenerator(TemplateClassDefinition<T> definition, OptionSet
optionManager) {
+ this(ClassGenerator.getDefaultMapping(), definition, optionManager);
--- End diff --
I traced through the code and asked IntelliJ where the variable is used.
This is what I found:
1. CodeGenerator accepts it as an argument to its constructor
1. It is then passed to the constructor of the EvaluationVisitor
1. A private field is set with the value in the constructor of
EvaluationVisitor
1. This private field of EvaluationVisitor is then unused.
If your not convinced let's walk through the code when I'm in the office
next week.
---
