Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145297229
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java ---
@@ -559,7 +563,7 @@ public void testRankWithGroupBy() throws Exception {
@Test // DRILL-3404
public void testWindowSumAggIsNotNull() throws Exception {
- String query = String.format("select count(*) cnt from (select sum (
c1 ) over ( partition by c2 order by c1 asc nulls first ) w_sum from
dfs.`%s/window/table_with_nulls.parquet` ) sub_query where w_sum is not null",
TEST_RES_PATH);
+ String query = "select count(*) cnt from (select sum ( c1 ) over (
partition by c2 order by c1 asc nulls first ) w_sum from
dfs.`/window/table_with_nulls.parquet` ) sub_query where w_sum is not null";
--- End diff --
Right about now I have to give you a huge THANKS! This is a huge amount of
clean-up you've done. These are really good improvements. Really appreciate the
tedious work to get this all done.
---
