Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/1024#discussion_r149506412 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java --- @@ -237,6 +245,127 @@ public String toString() { } } + /** + * Test for reading of default query timeout + */ + @Test + public void testDefaultGetQueryTimeout() throws SQLException { + PreparedStatement stmt = connection.prepareStatement(SYS_VERSION_SQL); + int timeoutValue = stmt.getQueryTimeout(); + assert( 0 == timeoutValue ); + } + + /** + * Test Invalid parameter by giving negative timeout + */ + @Test ( expected = InvalidParameterSqlException.class ) + public void testInvalidSetQueryTimeout() throws SQLException { + PreparedStatement stmt = connection.prepareStatement(SYS_VERSION_SQL); + //Setting negative value + int valueToSet = -10; + if (0L == valueToSet) { + valueToSet--; + } + try { + stmt.setQueryTimeout(valueToSet); + } catch ( final Exception e) { + // TODO: handle exception + assertThat( e.getMessage(), containsString( "illegal timeout value") ); + //Converting this to match expected Exception + throw new InvalidParameterSqlException(e.getMessage()); --- End diff -- Yep. Agree. Was trying to make use of the large number of `###SqlException`s defined within the Drill JDBC package. Will fix this. +1
---