[GitHub] drill pull request #1024: DRILL-3640: Support JDBC Statement.setQueryTimeout...

[laurentgo]

Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1024#discussion_r149543163
  
    --- Diff: 
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
    @@ -376,6 +417,19 @@ synchronized void cleanup() {
         currentBatchHolder.clear();
       }
     
    +  long getTimeoutInMilliseconds() {
    +    return timeoutInMilliseconds;
    +  }
    +
    +  //Set the cursor's timeout in seconds
    +  void setTimeout(int timeoutDurationInSeconds){
    +    this.timeoutInMilliseconds = timeoutDurationInSeconds*1000L;
    --- End diff --
    
    Preferably use `TimeUnit.SECONDS.toMillis(timeoutDurationInSeconds)` to 
avoid magic constants


---