Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150073673
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetComparison.java
---
@@ -255,4 +257,39 @@ private void verifyArray(String colLabel, ArrayReader
ea,
}
}
}
+
+ // TODO make a native RowSetComparison comparator
+ public static class ObjectComparator implements Comparator<Object> {
--- End diff --
Defined here, but not used in this file. Does not include all types that
Drill supports (via the RowSet): Date, byte arrays, BigDecimal, etc. Does not
allow for ranges for floats & doubles as does JUnit. (Two floats are seldom
exactly equal.)
---
