Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r150098888
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetComparison.java
---
@@ -255,4 +257,39 @@ private void verifyArray(String colLabel, ArrayReader
ea,
}
}
}
+
+ // TODO make a native RowSetComparison comparator
+ public static class ObjectComparator implements Comparator<Object> {
--- End diff --
This is used in the DrillTestWrapper to verify the ordering of results. I
agree this is not suitable for equality tests, but it's intended to be used
only for ordering tests. I didn't add support for all the supported RowSet
types because we would first have to move DrillTestWrapper to use RowSets
(currently it uses Maps and Lists to represent data). Currently it is not used
by RowSets, but the intention is to move DrillTestWrapper to use RowSets and
then make this comparator operate on RowSets, but that will be an incremental
process.
---
