Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r150131105
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -96,6 +105,14 @@ private void throwIfClosed() throws
AlreadyClosedSqlException,
throw new AlreadyClosedSqlException( "ResultSet is already
closed." );
}
}
+
+ //Implicit check for whether timeout is set
+ if (elapsedTimer != null) {
--- End diff --
Yes, I'm wrong? (asking because the rest of the sentence suggest I was
right in my interpretation of the test). Maybe we can/should test both? I would
have like to test for the first batch, but it's not possible to access the
query id until `statement.execute()`, and I'd need it to unpause the request.
---
