Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149548759
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -333,8 +368,14 @@ void close() {
final int batchQueueThrottlingThreshold =
client.getConfig().getInt(
ExecConstants.JDBC_BATCH_QUEUE_THROTTLING_THRESHOLD );
- resultsListener = new ResultsListener(batchQueueThrottlingThreshold);
+ resultsListener = new ResultsListener(this,
batchQueueThrottlingThreshold);
currentBatchHolder = new RecordBatchLoader(client.getAllocator());
+ try {
+ setTimeout(this.statement.getQueryTimeout());
+ } catch (SQLException e) {
+ // Printing any unexpected SQLException stack trace
+ e.printStackTrace();
--- End diff --
I agree. Thankfully, the _caller_ does handle any thrown `SQLException`s,
so I'm going to pass this off to that. IMO, I don't think we'll have an issue
because the `Statement.setQueryTimeout()` would have handled any corner cases
before this is invoked via `execute()`
---
