Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1023#discussion_r150339444
--- Diff: pom.xml ---
@@ -442,7 +442,7 @@
-Dorg.apache.drill.exec.server.Drillbit.system_options="org.apache.drill.exec.compile.ClassTransformer.scalar_replacement=on"
-Ddrill.test.query.printing.silent=true
-Ddrill.catastrophic_to_standard_out=true
- -XX:MaxPermSize=512M -XX:MaxDirectMemorySize=3072M
+ -XX:MaxPermSize=512M -XX:MaxDirectMemorySize=4096M
--- End diff --
@paul-rogers I think there are a few choices available to us:
1. Keep this change in a separate commit (already done) and revert it once
the Batch Size Limitation work is done. The benefit is that the build will not
be broken up until the Batch Size work is in. I can make a note on the Batch
Size jira to revert this change as well.
1. Remove this change and suffer with a broken build until the Batch Size
work is complete. (not fun)
1. Delete the offending tests instead as part of this PR.
I am in favor of option **1**. I am strongly against option **2** since
ignoring build issues makes life much harder for everyone.
Please let me know what path forward you'd like to take.
---
