Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1023#discussion_r155938285
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -61,12 +63,14 @@
public class WorkManager implements AutoCloseable {
private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(WorkManager.class);
+ public static final long EXIT_TIMEOUT = 5_000L;
--- End diff --
Three nits:
1. We'll never wait decades, so this need not be a long.
2. Please encode units in the name: `EXIT_TIMEOUT_MS`
3. The underscore is great, but not entirely needed for four-digit numbers.
---
