Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1051#discussion_r153285121
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
    @@ -256,12 +239,14 @@ public void run() {
     
         // track how long the query takes
         queryManager.markStartTime();
    -    enqueuedQueries.dec();
         runningQueries.inc();
     
    +    queryText = queryRequest.getPlan();
    +    recordNewState(QueryState.PLANNING);
    --- End diff --
    
    why this code is moved out of the try block ? I believe getPlan can throw 
an exception which we should handle. Also, should this be handled under 
moveToState ? 


---

Reply via email to