Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1051#discussion_r153406564
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java
---
@@ -280,29 +280,29 @@ public void interrupted(final InterruptedException
ex) {
}
void updateEphemeralState(final QueryState queryState) {
- // If query is already in zk transient store, ignore the transient
state update option.
- // Else, they will not be removed from transient store upon
completion.
- if (!inTransientStore &&
-
!foreman.getQueryContext().getOptions().getOption(ExecConstants.QUERY_TRANSIENT_STATE_UPDATE))
{
- return;
- }
+ // If query is already in zk transient store, ignore the transient
state update option.
+ // Else, they will not be removed from transient store upon completion.
+ if (!inTransientStore &&
!foreman.getQueryContext().getOptions().getOption(ExecConstants.QUERY_TRANSIENT_STATE_UPDATE))
{
+ return;
+ }
- switch (queryState) {
+ switch (queryState) {
+ case PREPARING:
+ case PLANNING:
case ENQUEUED:
case STARTING:
case RUNNING:
case CANCELLATION_REQUESTED:
runningProfileStore.put(stringQueryId, getQueryInfo()); // store
as ephemeral query profile.
inTransientStore = true;
break;
-
case COMPLETED:
case CANCELED:
case FAILED:
try {
runningProfileStore.remove(stringQueryId);
inTransientStore = false;
- } catch(final Exception e) {
+ } catch (final Exception e) {
--- End diff --
Below. What is an "estore"? Is that a typo?
---
