Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1051#discussion_r153389793
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/QueryWorkUnit.java ---
    @@ -112,4 +115,46 @@ public void applyPlan(PhysicalPlanReader reader) 
throws ForemanSetupException {
           fragments.add(defn.applyPlan(reader));
         }
       }
    +
    +  /**
    +   * Converts list of stores fragments into json,
    +   * in case of exception returns text indicating that json was malformed.
    +   * Is used for debugging purposes.
    +   *
    +   * @return fragments json
    +   */
    +  public String convertFragmentToJson() {
    +    StringBuilder stringBuilder = new StringBuilder();
    +    final int fragmentCount = fragments.size();
    +    int fragmentIndex = 0;
    +    for (final PlanFragment planFragment : fragments) {
    +      final ExecProtos.FragmentHandle fragmentHandle = 
planFragment.getHandle();
    +      stringBuilder.append("PlanFragment(");
    --- End diff --
    
    This isn't really JSON, is it? JSON syntax does not include parens.
    
    Do we want the output to be valid JSON? Or, a text wrapper around a JSON 
payload?


---

Reply via email to