Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1051#discussion_r153406881
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/DefaultResourceManager.java
 ---
    @@ -73,13 +75,20 @@ public void setCost(double cost) {
         @Override
         public void admit() {
           // No queueing by default
    +      foreman.moveToState(UserBitShared.QueryResult.QueryState.STARTING, 
null);
    --- End diff --
    
    Would REALLY prefer that the resource manager not depend on the Foreman; 
makes unit testing impossible. The Foreman should depend on this class, but not 
the other way around.


---

Reply via email to