[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

[paul-rogers]

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1059#discussion_r155939350
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/NestedLoopJoinBatch.java
 ---
    @@ -418,4 +418,15 @@ protected void killIncoming(boolean sendUpstream) {
       public int getRecordCount() {
         return outputRecords;
       }
    +
    +  @Override
    +  protected boolean checkForEarlyFinish() {
    +    if (popConfig.getJoinType() == JoinRelType.INNER &&
    +        (leftUpstream == IterOutcome.NONE || rightUpstream == 
IterOutcome.NONE) ||
    +        popConfig.getJoinType() != JoinRelType.INNER &&
    +            (leftUpstream == IterOutcome.NONE && rightUpstream == 
IterOutcome.NONE)) {
    +      return true;
    +    }
    +    return false;
    --- End diff --
    
    Maybe eliminate if as described above.


---