Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593808
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoinAdvanced.java
---
@@ -253,4 +259,52 @@ public void testDrill4196() throws Exception {
.baselineValues(6000*800L)
.go();
}
+
+ private void buildFile(String fileName, String[] data, File testDir)
throws IOException {
+ try(PrintWriter out = new PrintWriter(new FileWriter(new File(testDir,
fileName)))) {
+ for (String line : data) {
+ out.println(line);
+ }
+ }
+ }
--- End diff --
The above duplicates code in the hash join test. In general, duplicate code
is a "bad thing." Suggestion: move this code into a utilities class; maybe one
that already exists.
---
