[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

[ilooner]

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1045#discussion_r156208221
  
    --- Diff: 
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
    @@ -45,13 +45,11 @@
     
       private final ImmutableList<String> startupArguments;
     
    -  public static final boolean ON_OSX = 
System.getProperty("os.name").contains("OS X");
    -
       @SuppressWarnings("restriction")
       private static final long MAX_DIRECT_MEMORY = 
sun.misc.VM.maxDirectMemory();
     
       @VisibleForTesting
    -  public DrillConfig(Config config, boolean enableServerConfigs) {
    +  public DrillConfig(Config config) {
    --- End diff --
    
    The flag is actually an unused argument. Maybe it did something at one 
point but the code that used it is long gone.


---