Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156244298 --- Diff: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcBatchCreator.java --- @@ -33,10 +32,10 @@ public class JdbcBatchCreator implements BatchCreator<JdbcSubScan> { @Override public ScanBatch getBatch(FragmentContext context, JdbcSubScan config, - List<RecordBatch> children) throws ExecutionSetupException { + List<RecordBatch> children) throws ExecutionSetupException { Preconditions.checkArgument(children.isEmpty()); JdbcStoragePlugin plugin = config.getPlugin(); - RecordReader reader = new JdbcRecordReader(context, plugin.getSource(), config.getSql(), plugin.getName()); + RecordReader reader = new JdbcRecordReader(plugin.getSource(), config.getSql(), plugin.getName()); --- End diff -- Which file did I remove the POP config from? I can't seem to find it.
---