Checked checksums and signature on the release artifacts. Completed unit tests on Mac. Checked some random queries on complex integer types.
LGTM. +1 (binding) Note : Took a while to get the unit test issues resolved but the issues were on my system. On Wed, Dec 13, 2017 at 12:19 PM, Jinfeng Ni <[email protected]> wrote: > I also saw failures in TestGracefulShutdown and TestImpersonationMetadata, > when run "mvn clean install " on Mac. > > > > On Wed, Dec 13, 2017 at 12:01 PM, Parth Chandra <[email protected]> wrote: > > > I've resolved the problem causing TestGracefulShutdown. > testRestApiShutdown > > to fail for me. ( I had another drill bit running on my system that had > > failed to shut down). > > This test can be improved to take care of these situations, but for the > > moment I don't see this as a show stopper. > > > > On Wed, Dec 13, 2017 at 11:25 AM, Karthikeyan Manivannan < > > [email protected]> wrote: > > > > > > > > I downloaded the tarball and I see a timeout failure when I run > > > TestGracefulShutdown.testRestApiShutdown. > > > Building the ClusterFixture takes about 74 seconds (this takes only 5 > > secs > > > on Linux) and the test has a 60s wait and so this hits the 100s > timeout. > > > Did anyone manage to run this test on a Mac ? > > > Parth also had problems running this test. > > > > > > > > > > > > On December 13, 2017 at 10:10:11 AM, Aman Sinha ([email protected] > > > <mailto:[email protected]>) wrote: > > > > > > - Downloaded the source tarball from [2] on my Linux VM, built and ran > > all > > > unit tests successfully. > > > - Downloaded the binary tarball onto my Macbook, untarred and ran Drill > > in > > > embedded mode > > > - Ran a few sanity test queries against a TPC-DS SF1 data set. > > > - Examined the run-time query profiles of these queries with and > without > > > parallelism. Checked DEBUG logs for couple of queries. > > > - Checked the maven artifacts on [3]. > > > > > > LGTM +1 (binding) > > > > > > -Aman > > > > > > On Wed, Dec 13, 2017 at 7:58 AM, Vova Vysotskyi <[email protected]> > > wrote: > > > > > > > Ran Drill in embedded mode from a built archive at [2], again created > > and > > > > queried views, submitted few TPCH and TPCDS queries from a command > line > > > and > > > > UI, verified queries result, checked that query profiles are > displayed > > > > correctly. > > > > Ran queries from a simple java application using prebuilt drill-jdbc > > > > -driver. > > > > Connected from SQuirrel using prebuilt drill-jdbc-driver, ran few > > > > queries. Everything still works fine for me. > > > > Also, downloaded source archive at [2], ran unit tests, all tests are > > > > passed with a total time 33:10 min. > > > > > > > > +1 (non-binding) > > > > > > > > 2017-12-12 5:06 GMT+02:00 Prasad Nagaraj Subramanya < > > > [email protected] > > > > >: > > > > > > > > > * Built source tarball from [4] > > > > > * All unit tests passed on linux. Total time - 38:45 min > > > > > * All functional and advanced tests passed > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > > On Mon, Dec 11, 2017 at 12:37 PM, <[email protected]> > > > wrote: > > > > > > > > > > > Tested (pre-build archive): > > > > > > + Muliple complex queries on single drillbit (multiple joined > > storage > > > > > > types) > > > > > > + Queries on drillbit cluster > > > > > > + Multiple clients connected with pre-build drill-jdbc driver and > > > > custom > > > > > > authenticator > > > > > > + Query from web frontend > > > > > > + Queries with network functions > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Kind regards, > > > > Volodymyr Vysotskyi > > > > > > > > > >
