Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1040#discussion_r158118993
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/FORMSecurityHanlder.java
 ---
    @@ -0,0 +1,50 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.server.rest.auth;
    +
    +import org.apache.drill.common.exceptions.DrillException;
    +import org.apache.drill.exec.rpc.security.plain.PlainFactory;
    +import org.apache.drill.exec.server.DrillbitContext;
    +import org.apache.drill.exec.server.rest.WebServerConstants;
    +import org.eclipse.jetty.security.authentication.FormAuthenticator;
    +
    +public class FORMSecurityHanlder extends 
DrillHttpConstraintSecurityHandler {
    +  //private static final org.slf4j.Logger logger = 
org.slf4j.LoggerFactory.getLogger(FORMSecurityHanlder.class);
    +
    +  public static final String HANDLER_NAME = "FORM";
    +
    +  @Override
    +  public String getImplName() {
    +    return HANDLER_NAME;
    --- End diff --
    
    Didn't used it earlier since it was not used consistently by Jetty itself. 
See 
`org.eclipse.jetty.security.authentication.FormAuthenticator::getAuthMethod()`


---

Reply via email to