[GitHub] drill pull request #1040: DRILL-5425: Support HTTP Kerberos auth using SPNEG...

[sohami]

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1040#discussion_r158099695
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java
 ---
    @@ -69,23 +79,94 @@ public Viewable getLoginPage(@Context 
HttpServletRequest request, @Context HttpS
         return ViewableWithPermissions.createLoginPage(null);
       }
     
    +  @GET
    +  @Path(WebServerConstants.SPENGO_LOGIN_RESOURCE_PATH)
    +  @Produces(MediaType.TEXT_HTML)
    +  public Viewable getSpnegologin(@Context HttpServletRequest request, 
@Context HttpServletResponse response,
    +                                 @Context SecurityContext sc, @Context 
UriInfo uriInfo,
    +                                 
@QueryParam(WebServerConstants.REDIRECT_QUERY_PARM) String redirect) throws 
Exception {
    +    if (AuthDynamicFeature.isUserLoggedIn(sc)) {
    +      request.getRequestDispatcher("/").forward(request, response);
    --- End diff --
    
    Done


---