[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

[vvysotskyi]

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/570#discussion_r160492087
  
    --- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java 
---
    @@ -539,7 +553,12 @@ public void setValueLengthSafe(int index, int length) {
         }
     
     
    -    public void setSafe(int index, int start, int end, DrillBuf buffer){
    +<#if type.minor == "VarDecimal">
    --- End diff --
    
    I suppose condition should be negated or if and else should be swapped


---