Github user daveoshinsky commented on a diff in the pull request:
https://github.com/apache/drill/pull/570#discussion_r160791971
--- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java
---
@@ -539,7 +553,12 @@ public void setValueLengthSafe(int index, int length) {
}
- public void setSafe(int index, int start, int end, DrillBuf buffer){
+<#if type.minor == "VarDecimal">
--- End diff --
Is this what you're talking about? It looks OK to me.
<#if type.minor == "VarDecimal">
public void setSafe(int index, int start, int end, DrillBuf buffer, int
scale)
<#else>
public void setSafe(int index, int start, int end, DrillBuf buffer)
</#if> <#-- type.minor -->
---
