Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r160542798
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -333,4 +339,55 @@ public void testNlJoinWithLargeRightInputSuccess()
throws Exception {
test(RESET_JOIN_OPTIMIZATION);
}
}
+
+ private static void buildFile(String fileName, String[] data, File
testDir) throws IOException {
+ try(PrintWriter out = new PrintWriter(new FileWriter(new File(testDir,
fileName)))) {
+ for (String line : data) {
+ out.println(line);
+ }
+ }
+ }
+
+ public static void testWithEmptyJoin(File testDir, String joinType,
+ String joinPattern, long result) throws
Exception {
+ buildFile("dept.json", new String[0], testDir);
+ String query = String.format(testEmptyJoin, joinType);
+ testPlanMatchingPatterns(query, new String[]{joinPattern}, new
String[]{});
+ testBuilder()
+ .sqlQuery(query)
+ .unOrdered()
+ .baselineColumns("cnt")
+ .baselineValues(result)
+ .build().run();
+ }
+
+ @Test
+ public void testNestedLeftJoinWithEmptyTable() throws Exception {
+ try {
+ test(DISABLE_NLJ_SCALAR);
+ testWithEmptyJoin(dirTestWatcher.getRootDir(), "left outer",
nlpattern, 1155L);
+ } finally {
+ test(RESET_HJ);
--- End diff --
Please use `client.resetSessionOption(...)`.
---
