Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1059#discussion_r162294377
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/JoinTestBase.java
 ---
    @@ -0,0 +1,70 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.physical.impl.join;
    +
    +import org.apache.drill.categories.OperatorTest;
    +import org.apache.drill.PlanTestBase;
    +import org.apache.drill.common.exceptions.UserRemoteException;
    +import org.junit.BeforeClass;
    +import org.junit.Test;
    +import org.junit.experimental.categories.Category;
    +import java.io.File;
    +import java.io.FileWriter;
    +import java.io.IOException;
    +import java.io.PrintWriter;
    +import java.nio.file.Paths;
    +import org.apache.drill.exec.planner.physical.PlannerSettings;
    +import static org.hamcrest.CoreMatchers.containsString;
    +import static org.junit.Assert.assertThat;
    +
    +
    +@Category(OperatorTest.class)
    +public class JoinTestBase extends PlanTestBase {
    +
    +  private static final String testEmptyJoin = "select count(*) as cnt from 
cp.`employee.json` emp %s join dfs.`dept.json` " +
    +          "as dept on dept.manager = emp.`last_name`";
    +
    +  /**
    +   * This function runs a join query with one of the table generated as an
    --- End diff --
    
    function -> method


---

Reply via email to