[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

[daveoshinsky]

Github user daveoshinsky commented on a diff in the pull request:

    https://github.com/apache/drill/pull/570#discussion_r161069079
  
    --- Diff: 
common/src/main/java/org/apache/drill/common/util/CoreDecimalUtility.java ---
    @@ -32,6 +32,14 @@ public static long getDecimal18FromBigDecimal(BigDecimal 
input, int scale, int p
       }
     
       public static int getMaxPrecision(TypeProtos.MinorType decimalType) {
    +/*
    --- End diff --
    
    The two DAO comments are removed in my local merge environment.


---