[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

[vvysotskyi]

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/570#discussion_r160963518
  
    --- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java 
---
    @@ -327,13 +327,17 @@ public Mutator getMutator(){
         return v;
       }
     
    -  public void copyFrom(int fromIndex, int thisIndex, 
Nullable${minor.class}Vector from){
    +  protected void copyFromUnsafe(int fromIndex, int thisIndex, 
Nullable${minor.class}Vector from){
    --- End diff --
    
    Since we already have `copyFromSafe()` method in this class, `copyFrom()` 
is supposed to be unsafe.


---