Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1083#discussion_r161205848
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/TestJoinNullable.java ---
    @@ -568,6 +570,22 @@ public void nullMixedComparatorEqualJoinHelper(final 
String query) throws Except
             .go();
       }
     
    +  /** InnerJoin with empty dir table on nullable cols, MergeJoin */
    +  // TODO: the same tests should be added for HashJoin operator, DRILL-6070
    +  @Test
    --- End diff --
    
    Please add test for merge join with ignore annotation. Also please check 
that NLJ also works fine. If not, please fix.


---

Reply via email to