Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1083#discussion_r165023581
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/TestJoinNullable.java ---
    @@ -568,6 +570,22 @@ public void nullMixedComparatorEqualJoinHelper(final 
String query) throws Except
             .go();
       }
     
    +  /** InnerJoin with empty dir table on nullable cols, MergeJoin */
    +  // TODO: the same tests should be added for HashJoin operator, DRILL-6070
    +  @Test
    --- End diff --
    
    The bug was founded for NLJ and empty tables. I have resolved that issue.
    The separate test class is added for empty dir tables and different join 
operators.
    
    Also I have made refactoring for the TestHashJoinAdvanced, 
TestMergeJoinAdvanced, TestNestedLoopJoin classes.


---

Reply via email to