Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162499201
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/TestAffinityCalculator.java
---
@@ -21,18 +21,14 @@
import org.apache.drill.exec.ExecTest;
import org.apache.drill.exec.proto.CoordinationProtos;
-import org.apache.drill.exec.store.parquet.ParquetGroupScan;
import org.apache.hadoop.fs.BlockLocation;
import org.junit.Test;
import com.google.common.collect.ImmutableRangeMap;
import com.google.common.collect.Range;
public class TestAffinityCalculator extends ExecTest {
- static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(TestAffinityCalculator.class);
-
- String port = "1234";
- final String path = "path";
+ private final String port = "1234";
--- End diff --
- Two tests were blatantly commented out.
- testSetEndpointBytes
- testApplyAssignments
- Several methods were unused according to IntelliJ and the java compiler.
- buildRowGroups
- buildEndpoints
- buildBlockLocations2
After removing the unused code there is shockingly almost nothing left.
There are basically no functioning unit tests for the AffinityCalculator.
---
