Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162512220
--- Diff: exec/java-exec/src/test/java/org/apache/drill/PlanningBase.java
---
@@ -58,23 +55,24 @@
import com.google.common.collect.ImmutableList;
import com.google.common.io.Resources;
-public class PlanningBase extends ExecTest{
- //private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(PlanningBase.class);
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
--- End diff --
This test was previously using JMockit and I have simply replaced it with
Mockito which is Eclipse friendly and a step forward for developers using
Eclipse. So the amount of Mocking going on here is the same :) the only
difference is that Eclipse users should now be able to run these tests. I have
also completely removed mocking from some tests which no longer need it. As we
take more steps to properly use interfaces for more classes, we can
incrementally remove Mockito from even more tests. However, this is an
incremental process and shouldn't be done all in one shot.
---
