Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r163449000 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaRecordReader.java --- @@ -66,13 +66,12 @@ public KafkaRecordReader(KafkaSubScan.KafkaSubScanSpec subScanSpec, List<SchemaPath> projectedColumns, FragmentContext context, KafkaStoragePlugin plugin) { setColumns(projectedColumns); - this.enableAllTextMode = context.getOptions().getOption(ExecConstants.KAFKA_ALL_TEXT_MODE).bool_val; - this.readNumbersAsDouble = context.getOptions() - .getOption(ExecConstants.KAFKA_READER_READ_NUMBERS_AS_DOUBLE).bool_val; - OptionManager options = context.getOptions(); - this.unionEnabled = options.getOption(ExecConstants.ENABLE_UNION_TYPE); - this.kafkaMsgReader = options.getOption(ExecConstants.KAFKA_RECORD_READER).string_val; - this.kafkaPollTimeOut = options.getOption(ExecConstants.KAFKA_POLL_TIMEOUT).num_val; + final OptionSet optionSet = context.getOptionSet(); + this.enableAllTextMode = optionSet.getOption(ExecConstants.KAFKA_ALL_TEXT_MODE).bool_val; + this.readNumbersAsDouble = optionSet.getOption(ExecConstants.KAFKA_READER_READ_NUMBERS_AS_DOUBLE).bool_val; + this.unionEnabled = optionSet.getOption(ExecConstants.ENABLE_UNION_TYPE); + this.kafkaMsgReader = optionSet.getOption(ExecConstants.KAFKA_RECORD_READER).string_val; + this.kafkaPollTimeOut = optionSet.getOption(ExecConstants.KAFKA_POLL_TIMEOUT).num_val; --- End diff -- Would be a good code cleanup task to control entropy. However, this is the kind of thing that can be done incrementally over time as the need arises. Also, standardizing on session/system option names would be good: maybe `_KEY` for names, `_VALIDATOR` for validators.
---